update doh (and dot) examples

mafintosh / dns-packet

An abstract-encoding compliant module for encoding / decoding DNS packets

MIT License

201 stars 70 forks source link

update doh (and dot) examples #54

Closed kimbo closed 4 years ago

kimbo commented 4 years ago

Updated broken examples/doh.js to match Google's current API (see https://developers.google.com/speed/public-dns/docs/doh for details)
Switched out getdnsapi.net for 1.1.1.1 (Cloudflare) in examples/tls.js. getdnsapi.net resolves to 185.49.141.37, and it looks like an authoritative server (it also appears to not support DNS over TLS).

kimbo commented 4 years ago

Well apparently I should've mentioned an RFC - see https://github.com/mafintosh/dns-packet/pull/58

pusateri commented 4 years ago

Sorry, I didn’t see your pull request at the time I got a private email about this. Thanks for contributing. It was my oversight, not your description.

kimbo commented 4 years ago

No worries lol. And you're welcome. I know maintaining a project is hard, you can't always respond to everything, and the example code isn't what I'd call "critical". So I appreciate your comment.