search

mafintosh / dns-packet

An abstract-encoding compliant module for encoding / decoding DNS packets
MIT License
205 stars 71 forks source link

implement the NAPTR record #89

Closed xuhjbj closed 1 year ago

xuhjbj commented 1 year ago

Why

There is a requirement for support NAPTR record type. So open a issue https://github.com/mafintosh/dns-packet/issues/87 to address.

What

Pull Request for this with @silverwind suggestion .

silverwind commented 1 year ago

Please add it to "Supported Record Types" in README.md, otherwise I think it looks good.

xuhjbj commented 1 year ago

we had updated the README.md,please check.thanks

xuhjbj commented 1 year ago

please review,and merge .Thanks.

silverwind commented 1 year ago

I fixed lint, but tests are failing, please check.

xuhjbj commented 1 year ago

I fixed the issue,please help review ,thanks.