search

mafintosh / dns-packet

An abstract-encoding compliant module for encoding / decoding DNS packets
MIT License
207 stars 71 forks source link

what is node010? #9

Closed Pomax closed 7 years ago

Pomax commented 7 years ago

Installing this package drops an 11MB (!) file called "node010" in the module dir: what is this file? Is this, as the name might seem to suggest, a single-file compiled node 0.10? What is it used for? Can the README.md be extend to explain what this file is and what its security implications are (because this is a DNS package, there are always security implications)

mafintosh commented 7 years ago

Was prob published by accident. Either way, latest version (1.2.2) doesn't have this accidental file.

mafintosh commented 7 years ago

Ah, see #8

silverwind commented 7 years ago

Yes, my fault. I tend to leave unrelated files in package directories because I use files in all my projects to define exactly what gets published. Anyways, I've added files to both dns-packet and dns-socket now to prevent future issues.

Pomax commented 7 years ago

cool, I'll let the create-react-app folks know that they might want to have a quick look at their dependency chain (ran into this while bootstrapping a throw-away react app =)