Closed M4t7e closed 1 year ago
Merging #93 (2741e95) into master (519f55d) will increase coverage by
0.01%
. The diff coverage is100.00%
.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 97.97% 97.99% +0.01%
==========================================
Files 6 6
Lines 2026 2046 +20
==========================================
+ Hits 1985 2005 +20
Misses 41 41
Files Changed | Coverage Δ | |
---|---|---|
index.js | 98.06% <100.00%> (+0.02%) |
:arrow_up: |
According to RFC 1035 (but initially defined in RFC 883), email addresses can be represented as domain names in SOA (RNAME) and RP (MBOX) Records. An email address consists of two parts, a local part and the domain (
<local part>@<domain>
). Currently,dns-packet
does not support proper processing of email addresses if the local part contains dots (.
). E-mail DNS labels in the local part are allowed to contain a dot, which must be escaped by\.
in the representation format. With wire format, the label size is simply set to span the entire label, including all dots.SOA (RFC 1035):
RP (RFC 1183):
dig example:
dns-packet example after this change:
peter\.van\.dijk.powerdns.com
->peter.van.dijk@powerdns.com
This PR should also fix #90