search

mafintosh / dns-packet

An abstract-encoding compliant module for encoding / decoding DNS packets
MIT License
201 stars 70 forks source link

add setting unicast bit #96

Open XiXiangFiles opened 10 months ago

XiXiangFiles commented 10 months ago

Description:

for the unicast bit issue
I just rebase to the latest. previous pr: https://github.com/mafintosh/dns-packet/pull/49

related issues

https://github.com/mafintosh/dns-packet/issues/21

codecov-commenter commented 10 months ago

Codecov Report

Merging #96 (ab17088) into master (7b66620) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   97.99%   98.00%   +0.01%     
==========================================
  Files           6        6              
  Lines        2046     2057      +11     
==========================================
+ Hits         2005     2016      +11     
  Misses         41       41
Files Coverage Δ
index.js 98.08% <100.00%> (+0.01%) :arrow_up:
silverwind commented 10 months ago

See https://github.com/mafintosh/dns-packet/pull/94#issuecomment-1807954392

XiXiangFiles commented 10 months ago

@silverwind thx for your reviewing. I modify it to qu from QU. Thank you for continuing to leave comments on the Pull Request from many years ago