search

mafintosh / duplexify

Turn a writable and readable stream into a streams2 duplex stream with support for async initialization and streams1/streams2 input
MIT License
190 stars 36 forks source link

Drop dependency on readable-stream #23

Closed JustinBeckwith closed 5 years ago

JustinBeckwith commented 5 years ago

It feels like the implementation of streams in Node.js 6+ has settled down a great deal. Would you consider a PR to drop the dependency on the user space implementation of readable-stream? Or are there good reasons to keep on using it?

phated commented 5 years ago

https://r.va.gg/2014/06/why-i-dont-use-nodes-core-stream-module.html

JustinBeckwith commented 5 years ago

Thanks! I totally understand the advantage of the readable-stream package.. a few years ago :) A lot of what Rod wrote about was true in the pre-4.x world. As of today though, I'd argue that streams have settled. The API seems fairly locked in, and functionality is pretty much the same across Node 6 => 11 AFAICT. I am absolutely not the expert here though :)

mafintosh commented 5 years ago

Being part of the streams working group readable-stream is still very much needed as there and bigger changes still happening underneat the hood of streams

JustinBeckwith commented 5 years ago

Thanks! Can you give a TL;DR of what those changes look like? We're trying to evaluate our usage of streams across all of the Google npm modules, and I find myself often conflicted 😁

phated commented 5 years ago

I'll let mafintosh speak to changes but I'm going to close this so it doesn't show up on my github dashboard.