search

mafintosh / duplexify

Turn a writable and readable stream into a streams2 duplex stream with support for async initialization and streams1/streams2 input
MIT License
190 stars 36 forks source link

Convert to TypeScript #24

Closed JustinBeckwith closed 3 years ago

JustinBeckwith commented 5 years ago

It would be rad if this library was written in TypeScript. I'd be happy to do the work and submit a PR if that would be welcomed :) This would make it easier to include a d.ts file for other TypeScript users, as well as the other TypeScript type advantages.

Would you be open to accepting a PR? I've prototyped it here. https://github.com/JustinBeckwith/duplexify

callmehiphop commented 5 years ago

I can understand if they'd want to keep this vanilla, but I'm curious if a PR containing just a declaration file would be accepted?

mafintosh commented 5 years ago

a ts file is fine, as long as there isn't any real maintenance burden with that.