search

mafintosh / duplexify

Turn a writable and readable stream into a streams2 duplex stream with support for async initialization and streams1/streams2 input
MIT License
190 stars 36 forks source link

add typescript support #28

Closed callmehiphop closed 5 years ago

callmehiphop commented 5 years ago

Closes #24

I should probably mention that I'm probably not the best person to do this, please be gentle!

I had some issues trying to subclass duplexify with the @types/duplexify module, I believe what I'm proposing will allow it to be done and remove the need for a wildcard import. Since I've added a default export, I think this is going to blow up anyone's project that is using @types/duplexify though.

phated commented 5 years ago

I always ping @blakeembrey when I have typescript questions 😹

JustinBeckwith commented 5 years ago

This is awesome, and will save me a lot of pain.

callmehiphop commented 5 years ago

I can understand if there is a desire to keep TS out of here, I'm pretty the only change we really need here is the default export.