Update dependencies - Githubissues

mafintosh / duplexify

Turn a writable and readable stream into a streams2 duplex stream with support for async initialization and streams1/streams2 input

MIT License

190 stars 36 forks source link

Open orgads opened 4 years ago

orgads commented 4 years ago

Do you really need to support Node v4? :/

mafintosh commented 4 years ago

Is there any of the versions not supported on 4 or are you referring to something else?

orgads commented 4 years ago

Yes, through2 v4.

jimmywarting commented 3 years ago

Would like to ask: do you still want to support node version below 12?

mafintosh commented 3 years ago

We’ll drop that and bump major when there is a bug fix that requires it :)

jimmywarting commented 3 years ago

We’ll drop that and bump major when there is a bug fix that requires it :)

So never then 😝

How about i make a PR that modernize the code?

const, let, class
require new keyword
using built in stream to always get latest updates with support for async iterator
including this PR that updates all dependencies (doe this is probably outdated now)
remove Buffer constructor (or possible switch to using Uint8array instead)
removes the legacy inherits
switch to ESM-only
using node: prefix

mafintosh commented 3 years ago

Sure, as long as it's Node 10+ and keep the test devs old tho (ie concat stream) so we know we don't break anything.

jimmywarting commented 3 years ago

so without ESM or node: prefix then... sure i can make such PR