search

mafintosh / fuse-bindings

Notice: We published the successor module to this here https://github.com/fuse-friends/fuse-native
MIT License
314 stars 60 forks source link

This don't builds anymore on current node ? What is the last supportet node version #77

Open frank-dspeed opened 4 years ago

frank-dspeed commented 4 years ago

I found out that this lib is not working on current nodejs versions what is the last supportet version?

jb33k commented 4 years ago

Builds fine with 10.17 but not with 11.x.

sam0x17 commented 4 years ago

you'll probably find everything works really nice with 8. That's around when this died.

frank-dspeed commented 4 years ago

Thanks for the feedback I think we should line that out in the README and attract new Maintainers that will update nan and the bindings.

piranna commented 4 years ago

Thanks for the feedback I think we should line that out in the README and attract new Maintainers that will update nan and the bindings.

And port to libfuse 3... I think @javiergarmon did some improvements towards this in the past in https://github.com/javiergarmon/fuse3-bindings.

alexander-girsh commented 4 years ago

I recently opened a pull-request with all updates required to use that with node 12/13. https://github.com/noguilty4you/fuse-bindings/tree/node-13-adaption

Unfortunately mr @mafintosh doesn't handle the PR's by now.

Tests passed and one of my customers uses it in production already.

frank-dspeed commented 4 years ago

@noguilty4you we should simply publish your maintained version if you like? We Should rename it a bit to make clear that yoru bindings are the current maintained once maybe @mafintosh is sick or dead i don't know him but i will take your version into my organisation and line out that it is the current maintained version i will also add you as maintainer and i will do automation for npm publishing thanks a lot for your effort

piranna commented 4 years ago

maybe @mafintosh is sick or dead i don't know him

The best way to say that is to check its github profile activity, and no, he's not dead :-) The last news I had from him is that he's busy with https://twitter.com/dat_project

mafintosh commented 4 years ago

The rumours of my death are greatly exaggerated

@piranna is fuse3 supported on osx?

Btw we’re about to release fuse-native, https://github.com/fuse-friends/fuse-native where we re-engineered the impl using napi and multithread support.

If anyone is interested in helping maintain this feel free to reach out.

piranna commented 4 years ago

The rumours of my death are greatly exaggerated

Lol :-P

@piranna is fuse3 supported on osx?

No idea, not an OSX user since 10 years ago... but a quick search says "no", only fuse2 :-(

Btw we’re about to release fuse-native, fuse-friends/fuse-native where we re-engineered the impl using napi and multithread support.

Nice! Is it based on fuse3? :-)

mafintosh commented 4 years ago

@piranna no fuse2.7 i think as that afaik is the only one ported to osx still. We very very very much would like to get 3 in there but osx support is still more important for our usecases.

You prob easily fork and switch to fuse3 tho as it’s mostly just “glue” code from c to js

piranna commented 4 years ago

We very very very much would like to get 3 in there but osx support is still more important for our usecases.

Ok, I totally understand.

You prob easily fork and switch to fuse3 tho as it’s mostly just “glue” code from c to js

Are you talking about fuse-native, or this one? For this one, @javiergarmon did some progress, maybe we could start working on a new v3 branch or in another repo until OSX support appears... What do you recomends?

piranna commented 4 years ago

According to https://github.com/osxfuse/osxfuse/issues/390, osxfuse is based in fuse 2.9.7, and although they would like to upgrade to libfuse 3... seems the project is dead, with no commits in 2 years :-(

alexander-girsh commented 4 years ago

@noguilty4you we should simply publish your maintained version if you like? We Should rename it a bit to make clear that yoru bindings are the current maintained once maybe @mafintosh is sick or dead i don't know him but i will take your version into my organisation and line out that it is the current maintained version i will also add you as maintainer and i will do automation for npm publishing thanks a lot for your effort

@frank-dspeed, if @mafintosh will release the fuse-native module soon, maybe we shouldn't create a 999,999,999th npm package? What do u think about it?

piranna commented 4 years ago

@frank-dspeed, if @mafintosh will release the fuse-native module soon, maybe we shouldn't create a 999,999,999th npm package? What do u think about it?

I agree, we should concentrate efforts.

frank-dspeed commented 4 years ago

@piranna i will still publish node-fuse-bindings with some extra stuff it will simply relay on @noguilty4you 's version till the fuse-nativ is ready and working better then the other version.

i will simply contribute back to what ever is used on my backend side maybe node will evolve also.

so its not so importent that anything gets released soon the current situation already forced me to use go as a coding lang as it got the most current fuse support. I need now to reevaluate if we can offer node support again.

piranna commented 4 years ago

Can you merge too all the open pull-requests? This would greatly helps to unify efforts, there are no so much forks and would clean-up things...

frank-dspeed commented 4 years ago

@piranna i have everthing in https://github.com/direktspeed/node-fuse-bindings exempt the 2 ts pull requests as i am not a typescript use you can simply install it via 

npm i -s node-fuse-bindings
piranna commented 4 years ago

@piranna i have everthing in direktspeed/node-fuse-bindings exempt the 2 ts pull requests as i am not a typescript use you can simply install it via

Have you implemented them yourself, copy the code, or done merging of the code commits?