search

mafintosh / hyperlog

Merkle DAG that replicates based on scuttlebutt logs and causal linking
MIT License
470 stars 33 forks source link

Include 'node' on 'reject' events. #33

Closed hackergrrl closed 7 years ago

hackergrrl commented 7 years ago

This brings the code in line with the API, which says that node ought to be included in the 'reject' event callback.

Does this feel weird? Technically the node doesn't exist in the hyperlog, so returning it back to the user might not really make sense. I'm also happy to just edit the API to explicitly say that no params are included in the 'reject' event.

cc @mafintosh

mafintosh commented 7 years ago

i think it's good to have in the event. might be useful is you are debugging why something is being rejected

mafintosh commented 7 years ago

4.11.1