mafintosh / hyperlog

Merkle DAG that replicates based on scuttlebutt logs and causal linking
MIT License
470 stars 33 forks source link

Bugfix: bad links prevent 'reject' from firing #34

Closed hackergrrl closed 7 years ago

hackergrrl commented 7 years ago

I found this by working backwards from a real mapeo-desktop dataset where hyperlog-index's "ready()" never fired.

Turns out a failure from getLinks() would prevent a 'reject' event from firing, keeping the preadd vs add/reject event count from balancing, which hyperlog-index relies on.

Includes bugfix and a regression test.

mafintosh commented 7 years ago

nice catch. 4.12.0