search

mafintosh / multicast-dns-service-types

Parse and stringify mdns service types
MIT License
15 stars 4 forks source link

Subtypes in front #2

Open wesleytodd opened 8 years ago

wesleytodd commented 8 years ago

According to this (I have no idea if it is trustworthy), the subtypes go on the front. I am a total noob with this so please point me to the right place if I am wrong.

I am working on implementing subtype support for https://github.com/watson/bonjour and was trying to figure out why my format based on that doc was not working. It turns out that it is due to this module not parsing the subtypes out as I expected.

Thanks!!

wesleytodd commented 8 years ago

More reference for this: https://tools.ietf.org/html/rfc6763#section-7.1

In this case, we define the "_printer" subtype of "_http._tcp", and to discover only the subset of pages advertised as having that subtype property, the web browser issues a query for "_printer._sub._http._tcp."

wesleytodd commented 8 years ago

Also, after digging into the tests, it looks like this the _sub part is being treated as an actual subtype. But I don't think that is the intent of the spec. I think anything before _sub is a subtype, like _sub is a separator.

Quote from the spec:

In this case, we define the "_printer" subtype of "_http._tcp", and to discover only the subset of pages advertised as having that subtype property, the web browser issues a query for "_printer._sub._http._tcp.".

To me this means that _printer is the subtype. Do you all read this differently?

mafintosh commented 8 years ago

It sounds like you're right. Send me some PRs to fix the issues you are raising.

wesleytodd commented 8 years ago

Will do!! I was already working on them last night. Not sure when I will be able to finish because Im going out of town for new years, but I will send them over asap.

wesleytodd commented 8 years ago

@mafintosh do you have any issues with this? https://github.com/watson/bonjour/issues/1#issuecomment-167719143