search

mafintosh / node-sodium-prebuilt

Prebuilds for the Lib Sodium port for node.js
MIT License
9 stars 6 forks source link

Update to node-sodium@1.1.12 #1

Closed justmoon closed 8 years ago

justmoon commented 8 years ago

Upstream has advanced quite a bit (1.0.22 -> 1.1.12) - dunno how useful this PR is, but I figured some kind of PR is better than showing up empty handed on Twitter. The whole thing is just 9e0d720 on top of the upstream tag 1.1.12.

Main issue was dealing with the changes to the preinstall and install targets in upstream's package.json. Since prebuild's --preinstall option doesn't support arguments, I used && and || which seems to work, but... not convinced this won't break in some situations.

Successfully tested npm run prebuild on Linux x64 and Win32 x64.

mafintosh commented 8 years ago

Thanks a bunch for this PR. I'll see if I can get it merged.

ralphtheninja commented 8 years ago

bump What's the status on this?

mafintosh commented 8 years ago

master is now 1.1.15, mostly based on the work here

mafintosh commented 8 years ago

and npm published with builds for linux + mac

dominictarr commented 8 years ago

broken because of this:

https://github.com/paixaop/node-sodium/commit/805b6f521db3f5049b4e961a6304b8b2ded63eec#commitcomment-19350734

mafintosh commented 8 years ago

@dominictarr dang, should we revert?

mafintosh commented 8 years ago

aka, unpublish this and wait for a fix

dominictarr commented 8 years ago

yes I think so, I already pinned to previous version in chloride, and submitted fix.

mafintosh commented 8 years ago

its unpublished now. when a new upstream release is made with your PRs i'll build + release a new version here.

justmoon commented 8 years ago

Upstream is now merged and released: https://github.com/paixaop/node-sodium/pull/89

justmoon commented 7 years ago

@mafintosh @dominictarr Since the upstream fix has been merged and released in 2.0.0/2.0.1, we should be ready to try this again.

dominictarr commented 7 years ago

👍

justmoon commented 7 years ago

@mafintosh Could you give this another go? Should be ok to pull in upstream now!

mafintosh commented 7 years ago

@justmoon i'm a swamped atm but i can add you as owner if you want to give it a try?

justmoon commented 7 years ago

@mafintosh Sure, I'd be happy to.

justmoon commented 7 years ago

Time for the bimonthly poke!

cc/ @mafintosh

mafintosh commented 7 years ago

@justmoon just added you. sorry for the delay. i'm personally just using https://github.com/mafintosh/sodium-native now