Peerflix does not correctly pass `--meta-title`

mafintosh / peerflix

Streaming torrent client for node.js

MIT License

6.19k stars 673 forks source link

Peerflix does not correctly pass `--meta-title` #372

Open lewisakura opened 3 years ago

lewisakura commented 3 years ago

I noticed on the command line, Peerflix passes --meta-title wrapped in quotes, and does not properly escape all quotes, as well as inserting quotes that weren't even in the file in the first place (probably explains why it isn't escaping all quotes, I just realised they weren't even in the file name): My quick skim of the code that deals with this shows no obvious issue, so I am not too sure why it's happening.

lewisakura commented 3 years ago

I fixed this by passing { windowsVerbatimArguments: true } as a parameter to process.execFile. Seems to be some weird thing with Node that screws with arguments specifically on Windows.