search

mafintosh / playback

Video player built using electron and node.js
https://mafintosh.github.io/playback/
MIT License
2.01k stars 237 forks source link

add support for play-pause, next track & previous track buttons #102

Closed phated closed 8 years ago

phated commented 8 years ago

I added global shortcuts tied to the media keys for Play/Pause and Next/Previous Track buttons. I also did work for volume up/down/mute but didn't include it in this PR because I'm not sure it makes sense. Do you think it should be supported or not (In VLC, they don't tie the volume control to those buttons)?

feross commented 8 years ago

Volume keys are usually left to the OS to handle.

phated commented 8 years ago

@feross yeah, thought so. I really like when you can control chromecast with volume buttons though (usually on Android).

feross commented 8 years ago

Oh, that's actually a neat idea. But I think users would find it very surprising on OS X.

On Thu, 14 Apr 2016 at 16:05 Blaine Bublitz notifications@github.com wrote:

@feross https://github.com/feross yeah, thought so. I really like when you can control chromecast with volume buttons though (usually on Android).

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/mafintosh/playback/pull/102#issuecomment-210196598

phated commented 8 years ago

@feross yeah, I'm currently thinking about a "preferences" menu option and maybe it could contain an option for that.

feross commented 8 years ago

That's amusing -- we're working on the same thing in WebTorrent Desktop right now.

freeall commented 8 years ago

I don't know any programs (at least in osx) that override volume up/down behaviour. But the rest are neat.

And a jumbo :+1: for controlling volume in Chromecast. I very often have that need. Often you then need "another" remote to control the volume and that's kinda stupid.