search

mafintosh / playback

Video player built using electron and node.js
https://mafintosh.github.io/playback/
MIT License
2.01k stars 237 forks source link

Validate file format #114

Open ppeczek opened 8 years ago

ppeczek commented 8 years ago

Right now, you can load any kind of files: documents, images etc. Playback then doesn't display them and stops at black frame. This behaviour looks like playback was suspended. Really needs file format validation!

screenshot from 2016-06-14 12 50 30 screenshot from 2016-06-14 12 57 34

freeall commented 8 years ago

That's a good idea. Is it something you would want to try to do @ppeczek?

ppeczek commented 8 years ago

Yes, but let's talk about it. My idea is quite naive: textfile with list of supported extensions, splitting filename by ".", checking if extension is supported 14 cze 2016 13:01 "Tobias Baunbæk" notifications@github.com napisał(a):

That's a good idea. Is it something you would want to try to do @ppeczek https://github.com/ppeczek?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mafintosh/playback/issues/114#issuecomment-225848519, or mute the thread https://github.com/notifications/unsubscribe/ACy8fuwQBTjCDbEaRAgXVopUiVa4DvVzks5qLooOgaJpZM4I1Mwi .

mafintosh commented 8 years ago

a module that does this would be cool (if it doesn't already exist)

ppeczek commented 8 years ago

Ok then, give me few hours and I will take care of this matter.

ppeczek commented 8 years ago

https://github.com/electron/electron/blob/master/docs/api/dialog.md I found it but just for dialog. It has nothing to do with validation. I've already written part of code for extensions. I have to do sanitizer and we're home