search

mafintosh / playback

Video player built using electron and node.js
https://mafintosh.github.io/playback/
MIT License
2.01k stars 237 forks source link

[feature request] Speed control #127

Open dawsbot opened 7 years ago

dawsbot commented 7 years ago

After searching through the docs and source code both, I don't see any video speed controls. Is that something supported already and if not, is it something welcome in a PR?

There is var pbrateSlider = $('#controls-pbrate-slider')[0] in the source, but I don't see any slider in the actual application. I'm playing an mp4 on MacOS Sierra v10.12.3.

Possibly related: https://github.com/mafintosh/playback/pull/120/files#diff-168726dbe96b3ce427e7fedce31bb0bcR723

phated commented 7 years ago

I believe I implemented this but there hasn't been a new release in awhile. If so, you can get it by making a custom build.

dawsbot commented 7 years ago

@mafintosh ~@phated~ would cutting a new release be possible instead? It seems like a useful feature that other people could also benefit from.

phated commented 7 years ago

I'm not a project owner.