mafintosh / playback

Video player built using electron and node.js
https://mafintosh.github.io/playback/
MIT License
2.01k stars 237 forks source link

remove prefix from links before matching #19

Closed jbenet closed 9 years ago

jbenet commented 9 years ago

when the playback:// protocol prefix is there, we cannot match other protocols correctly (e.g. only match /ipfs/... with /^\/ipfs\//)

I added a "\/*" to the ipfs regex because users will not like having to enter: playback:///ipfs/... and playback://ipfs/... should work

this makes these links work:

mafintosh commented 9 years ago

haha didn't see this fix. i just added this to master

jbenet commented 9 years ago

fixed in 2596a6be3a56fc7f433e24dc940d9cecffa6ed7e