mafintosh / playback

Video player built using electron and node.js
https://mafintosh.github.io/playback/
MIT License
2.01k stars 237 forks source link

graphical ui #2

Closed mafintosh closed 9 years ago

mafintosh commented 9 years ago

playback is a minimalistic video player build on top of atom-shell. it supports playing normal video files, video files shared using bittorrent, (and in the future, videos from youtube). it also has support for broadcasting what you're currently watching over the local network so that multiple people can watch the same video at the same time.

basic functionality is pretty much done but it needs a graphical ui. i'm thinking it should be as minimal as possible (think quicktime on osx) where there isn't any ui until you mouse over the player.

components wise we probably need

any help with the design aspect of this would be greatly appreciated :) am happy to implement from mockups, or whatever else works. leave ideas in the thread below

max-mapper commented 9 years ago

for minimalism the best peeps in the game are @jxnblk and @mrmrs, maybe http://jxnblk.com/skull/ would be useful here

jemory commented 9 years ago

I have some questions about the expected functionality of the top menubar.

One other question I have: what is the primary method of selecting a video for playback in the first place and how are videos added to the queue? File menu? Magnet Links? Drag and drop? All of the above? Something else?

Sounds like a cool app!

freeall commented 9 years ago

@jemory videos should probably be added through magnet links and drag and drop. I'm looking into getting the magnet links to work.

mafintosh commented 9 years ago

What should happen when the broadcast button is pressed? Any dialog involved?

No dialog is needed (the app just starts broadcasting to other people on the network that you are available for broadcast). The broadcast button could change state to show that you are broadcasting now.

What should happen when the button for selecting broadcasts is pressed? Would there be a list? Modal?

The way it works now is that when subscribing it just starts showing the first broadcast it finds on the network. I think we can continue with this behaviour for a while and worry about having modal later incase more than one is found.

Is the app aware of whether or not broadcasts are available? I.e., should the select button be permanent, or only visible when a broadcast is available?

Yes the app is aware so we could "gray" out the button if no broadcast is available

what is the primary method of selecting a video for playback in the first place and how are videos added to the queue? File menu? Magnet Links? Drag and drop? All of the above? Something else?

I'm thinking all of the above :)

mafintosh commented 9 years ago

@freeall nice! make a "registerProtocol" module :)

freeall commented 9 years ago

@mafintosh my thoughts exactly (about the module) :)

mafintosh commented 9 years ago

@freeall i made a separate issue for the protocol handler stuff in #3

bmathews commented 9 years ago

Here's somethin quick I threw together:

1) The bottom right icons are playlist (clicking would be some kind of popover with the list/management), broadcast, fullscreen 2) Peers/speed would show up if it's a torrent

image

If you like the direction, I could finish it up.

mafintosh commented 9 years ago

@jemory looks great! please finish it up :) i'm thinking we need a subscribe button as well? maybe that should just be located the same place add the "add file" buttons

mafintosh commented 9 years ago

I meant to mention @bmathews above

bmathews commented 9 years ago

Sure thing. For the list of available broadcasts, what kind of information will be available to us to show? Filename? IP? Computer name?

mafintosh commented 9 years ago

@bmathews all of the above :)

bmathews commented 9 years ago

Here are some quick ideas for broadcasting/subscribing and playing/streaming. Colors/states/alignment of things are real rough in these mockups.

¯_(ツ)_/¯

image

image

image

image

bmathews commented 9 years ago

Feel free to ignore any of these ideas or implement it differently. But maybe this helps or gives you some ideas/foundation to build on?

mafintosh commented 9 years ago

@bmathews thanks so much for making these. i'm gonna try to implement that now. btw which font are you using?

bmathews commented 9 years ago

Roboto. Can get here. Probably just need regular/medium/bold. http://www.google.com/fonts#UsePlace:use/Collection:Roboto

bmathews commented 9 years ago

Or I could add it later if you just want to use helvetica for now.

daviferreira commented 9 years ago

@bmathews nice work, beautiful stuff :+1:

mafintosh commented 9 years ago

@bmathews most of the ui is implemented now in master. i'm wondering what app should show when the playlist is empty (right now its just a black screen). any ideas?

bmathews commented 9 years ago

@mafintosh The cat's pretty good, but I'll keep thinking of some ideas.

freeall commented 9 years ago

I think the cat is good, but maybe it should have a few seconds of waiting after each wag

max-mapper commented 9 years ago

the idea behind the cat is that it will cause massive viral success of the app

freeall commented 9 years ago

@maxogden a cat virus if I'm not mistaken? A catirus

max-mapper commented 9 years ago

closing in favor of smaller, more focused issues