search

mafintosh / playback

Video player built using electron and node.js
https://mafintosh.github.io/playback/
MIT License
2.01k stars 237 forks source link

fixing tiny deprecated warnings #83

Closed cesine closed 8 years ago

cesine commented 8 years ago

there were two tiny deprecated warnings, with no apparent changes required in the code https://github.com/atom/electron/blob/3875b30fcf2065cebc4e914ee5274084875e425b/atom/browser/api/lib/ipc.js#L5

seems to be deprecated around November 10 2015 https://github.com/atom/electron/commit/844cea8f216539ad2233180ab28b934d060f12c7

$ npm start

> playback@1.6.0 start ~/playback
> electron app.js

(electron) ipc module is deprecated. Use require("electron").ipcMain instead.
(electron) loadUrl is deprecated. Use loadURL instead.
mafintosh commented 8 years ago

thanks :) i commented a minor style change

cesine commented 8 years ago

@mafintosh sorry about those ", fixed now

mafintosh commented 8 years ago

@cesine awesome. thank you!

cesine commented 8 years ago

thank you! this is an awesome example for what i'm working on :)

cesine commented 8 years ago

@tabrath thanks for catching this, i dug in and you're right: it needs to be ipcRenderer in the index.js and ipcMain in the app.js new pr: #87

tabrath commented 8 years ago

@cesine happy to help out.