search

mafintosh / playback

Video player built using electron and node.js
https://mafintosh.github.io/playback/
MIT License
2.01k stars 236 forks source link

ipcRenderer passes an event object as first argument since electron 0.35.0 #97

Closed phated closed 8 years ago

phated commented 8 years ago

Awesome project you've created here.

I wanted to do some development on it so I pulled it down and started poking at stuff; however, I quickly ran into a problem when attempting to add a file to the playlist. I dug into the devTools and found out that links was actually an event object, so I took a look at the electron changelog. It seems that they changed the API signature to ipcRenderer.on()'s callback in 0.35.0 (see https://github.com/electron/electron/releases/tag/v0.35.0) and playback uses ^0.35.4. I made the change and the "Add Media" is working again.

I'm not sure why the bundled version doesn't exhibit this behavior.

phated commented 8 years ago

@freeall thanks for merging my "repeat" PRs, could you also merge this due to the API being changed and the application not working off master?

phated commented 8 years ago

thanks!

freeall commented 8 years ago

Thank you for all the PR's. Super good to see!

phated commented 8 years ago

My pleasure. This is a really fun project to work on. I'll probably be sending some more incremental changes/features soon.