This wasn't strictly necessary but I noticed the octicon version was pretty old (2.4.1 when they are on 3.5.0 now) and looked into upgrading it because I was hoping they would have expanded the playback icons. I found out that they actually removed the playback icons in 3.0.0 (see https://github.com/github/octicons/releases/tag/v3.0.0); you can emulate some (like arrow for play, etc) but there wasn't a good replacement for pause. I switched it out for ionicons because they seem to be one of the best maintained and fully-featured icon libraries and it is available on npm now. They are working on their 3.0 release and it still has playback icons, so that's a good sign.
I also updated the JS code to use a separate class called .js-icon because the references to .mega-octicon tied it pretty heavily to that code and I couldn't quickly figure out why my button clicks weren't working when I swapped the classes.
This wasn't strictly necessary but I noticed the octicon version was pretty old (2.4.1 when they are on 3.5.0 now) and looked into upgrading it because I was hoping they would have expanded the playback icons. I found out that they actually removed the playback icons in 3.0.0 (see https://github.com/github/octicons/releases/tag/v3.0.0); you can emulate some (like arrow for play, etc) but there wasn't a good replacement for pause. I switched it out for ionicons because they seem to be one of the best maintained and fully-featured icon libraries and it is available on npm now. They are working on their 3.0 release and it still has playback icons, so that's a good sign.
I also updated the JS code to use a separate class called
.js-iconbecause the references to.mega-octicontied it pretty heavily to that code and I couldn't quickly figure out why my button clicks weren't working when I swapped the classes.