search

mafintosh / signalhub

Simple signalling server that can be used to coordinate handshaking with webrtc or other fun stuff.
MIT License
667 stars 95 forks source link

Subscribe to multiple channels #3

Closed bnolan closed 9 years ago

bnolan commented 9 years ago

.subscribe() accepts an array of channel names, messages broadcast to any subscribed channel will be received.

bnolan commented 9 years ago

Updated the PR with a test for slashes in names. Do you want me to rebase?

bnolan commented 9 years ago

Heya @mafintosh do you need anything from me here?

bnolan commented 9 years ago

Bump? :'(

mafintosh commented 9 years ago

@bnolan sorry about that - could you rebase against master? then I'll merge it :)

bnolan commented 9 years ago

I think that's it! :)

mafintosh commented 9 years ago

Nice. This isn't a breaking change right? (assuming you only use a single channel of course)

bnolan commented 9 years ago

Nope, not breaking, works exactly the same for single channels.

On Wed, May 27, 2015 at 8:47 AM, Mathias Buus notifications@github.com wrote:

Nice. This isn't a breaking change right? (assuming you only use a single channel ofcourse)

— Reply to this email directly or view it on GitHub https://github.com/mafintosh/signalhub/pull/3#issuecomment-105660075.

Regards, Ben Nolan

http://bennolan.com/

skype: bennolan cell: +64 21 770 662

mafintosh commented 9 years ago

Nice. I'll release this as soon as i get to my computer

mafintosh commented 9 years ago

Out in 4.1.0. Thanks!

bnolan commented 9 years ago

Thank you! Yay. :)

On Wednesday, May 27, 2015, Mathias Buus notifications@github.com wrote:

Out in 4.1.0. Thanks!

— Reply to this email directly or view it on GitHub https://github.com/mafintosh/signalhub/pull/3#issuecomment-105825272.

Regards, Ben Nolan

http://bennolan.com/

skype: bennolan cell: +64 21 770 662