search

mafintosh / signalhub

Simple signalling server that can be used to coordinate handshaking with webrtc or other fun stuff.
MIT License
667 stars 97 forks source link

Old version of through2 #30

Open AlbertoElias opened 6 years ago

AlbertoElias commented 6 years ago

This module uses an older major version of through2 than https://github.com/mafintosh/webrtc-swarm which makes them clash

mafintosh commented 6 years ago

Is that an issue? Feel free to PR a bump

AlbertoElias commented 6 years ago

Yeah, I was going to do a PR, but I noticed that https://github.com/maxogden/size-limit-stream uses the same version, so I needed a bit more time, on it.

It's an issue because if not, through2 gets bundled twice when using webrtc-swarm, as it requires signalhub, which is unnecessary. And there's also an issue with rollup which isn't capable of resolving it properly