search

mafintosh / tar-fs

fs bindings for tar-stream
MIT License
350 stars 75 forks source link

(WIP) Fix separators to be OS specific (fixes Windows) #77

Closed pablonete closed 6 years ago

pablonete commented 6 years ago

Processing a tar file in Windows creates a death loop in validate because file name was empty, which was the result of strip converting "package\index.js" into "" instead of expected "index.js".

pablonete commented 6 years ago

Hold on, I'm suspicious this is not the right fix. We need to support both "\" and "/" from Windows. This is a sample file failing on Windows currently: no-deps-1.0.0.tar.gz I'm going to use path.join and path.parse instead.

pablonete commented 6 years ago

I've updated my proposal so tar files with backslash separator work on any OS. I've written a test.

Then I've realized the TAR file specification is not required to support backslashes, so I'm closing this PR, anyone seeing value on this feel free to ping me.