search

mafintosh / tar-fs

fs bindings for tar-stream
MIT License
350 stars 75 forks source link

Add an option to ignore stat errors #93

Closed gramakri closed 1 year ago

gramakri commented 4 years ago

Fixes #81

mafintosh commented 4 years ago

Thanks! Do you think this should just be the default? Its because we buffer up filenames before we stat them I think this happens, so maybe it makes sense to ignore a deleted file.

gramakri commented 4 years ago

I think with the current API it's hard to return the information that something failed but the tar succeeded. That is, the equivalent of printing a warning but finishing anyway and returning an exit code (like tar does). Besides, if we make it the default, it's a behavior change and we have to bump the major version. I will leave it to you to decide :-)

For a start maybe if we can have the option, then it's a new release. And if we see people want it often, we can make it default. I have been using the fork of this module (with this patch) for ~6 months now in our product (cloudron.io) and it's been working well!

mafintosh commented 1 year ago

feel free to reopen if still relevant