search

mafintosh / tar-stream

tar-stream is a streaming tar parser and generator.
MIT License
406 stars 92 forks source link

Removed logically dead code from parse256 #109

Closed adamcohenrose closed 4 years ago

adamcohenrose commented 4 years ago

zero is always set to false -- why does the code have two conditionals that depend on it being true?

This dead code was in the original parse256 from node-tar as well... Perhaps it was being kept to keep the code as similar as possible?

mafintosh commented 4 years ago

good catch, thanks