search

mafintosh / tar-stream

tar-stream is a streaming tar parser and generator.
MIT License
411 stars 93 forks source link

Move to `streamx` for streams, `brittle` for testing, and `b4a` for buffer operations #143

Closed kasperisager closed 1 year ago

kasperisager commented 1 year ago

Closes #134 Closes #137

kasperisager commented 1 year ago

@mafintosh This is ready for review.

mafintosh commented 1 year ago

woo!

jimmywarting commented 1 year ago

personally i would have used more native methods rather than using b4a and used iterators instead of streamx

silverwind commented 1 year ago

I see this commit is the reason for the 3.0.0 major version bump, but I wonder what exactly here is the breaking change?

kasperisager commented 1 year ago

Streamx behaves differently from Node.js streams in several ways, so as a precaution the switch was considered a major change.

silverwind commented 1 year ago

I see. At least for my use case (simple extraction), it looks to be compatible.

mafintosh commented 1 year ago

It should be fully compat, just precaution

willm commented 1 year ago

I'm trying to upgrade to version 3 where I use this in conjunction with the koa framework. It seems like koa behaves differently when setting the response body to a nodejs stream. In version 3 (presumably because it's no longer a node stream), koa tries to serialise Pack as json. Is there a way to convert back to a node js stream in v3?