search

mafintosh / tar-stream

tar-stream is a streaming tar parser and generator.
MIT License
400 stars 93 forks source link

feat: add typescript definition #153

Open alvis opened 1 year ago

alvis commented 1 year ago

close #97

catdevnull commented 1 year ago

this doesn't seem to implement the async iterator things. neither does @types/tar-stream.

alvis commented 1 year ago

this doesn't seem to implement the async iterator things. neither does @types/tar-stream.

Thanks for reminding. Now the updated version includes the missing async iterator.

@mafintosh Please check again :)

aripalo commented 11 months ago

Great work @alvis 👍 I was about to start defining the types myself as the @types/tar-stream doesn't have the async iterator. Now I was able to copy-paste the definition until this PR is merged.

alvis commented 5 months ago

@mafintosh let's do a review and let me know if there's anything missing 😎

a-eid commented 3 months ago

any updates on this PR, any chance it'll be merged soon ?