create entry with base-256 size

mafintosh / tar-stream

tar-stream is a streaming tar parser and generator.

MIT License

400 stars 93 forks source link

create entry with base-256 size #160

Closed fbeauchamp closed 10 months ago

fbeauchamp commented 10 months ago

Hi,

We are using tar-streamin our open source software xen-orchestra . Tar stream support reading a size in base-256 format, but use the octal text format for writing an entry, silently limiting the size of each entry to 8.5GB, if not using pax header.

Our target tar consumer (virtual box) does not support pax. Would it be ok to make a PR using base-256 size for entry, or make it optional and throwing an error if a size overflow ?

Regards,

Florent

mafintosh commented 10 months ago

Sure, if easy to maintain

fbeauchamp commented 10 months ago

great I will do it this week.

fbeauchamp commented 10 months ago

Hi , after re-reading the code I saw that I use an older version ( 2.x) , the current version already use base-256 encode for the size ( from here https://github.com/mafintosh/tar-stream/blob/master/headers.js#L73 )

I am updating our code to handle the non node stream of the 3.x instead, and closing this issue.

Regards,