extract halts unexpectedly if predecessor stream is unzipped

mafintosh / tar-stream

tar-stream is a streaming tar parser and generator.

MIT License

408 stars 92 forks source link

Closed chpio closed 5 years ago

chpio commented 8 years ago

hi,

i encountered a bug with this package:

if used with gunzip-maybe or zlib.createGunzip() the output stops after a few file entries
if the content is pre-unzipped (the same tar.gz file stored uncompressed) everything goes well
if the stream is consumed in the extract.on('entry') handler everything goes well

ohh, i don't know if it's relevant, i noticed the stops occur after a large file entry.

mafintosh commented 8 years ago

you need to resume the content stream or pipe it somewhere

.on('entry', function (header, stream, next) {
  stream.resume()
  next()
})

chpio commented 8 years ago

ok, so the usage of the stream outside of the entry handler is unsupported? like passing it into another stream and consume it later?

mafintosh commented 8 years ago

no thats fully supported as long as you drain the stream at some point.

chpio commented 8 years ago

hmm, yeah, the problem is that "later"/"at some point" is never called if the stream is not consumed "early"

mafintosh commented 8 years ago

i'm not sure what you mean