I've been seeing warnings for a while when using the Yarn package manager about the Buffer constructor API being deprecated in favor of Buffer.from and Buffer.alloc.
Yarn depends on tar-stream, and two of tar-stream's dependencies use new Buffer, but happily newer versions of both those dependencies exist that check if the appropriate new API is available and use that instead.
buffer-alloc 1.2.0 bumps its dependency on buffer-fill to 1.0.0, which includes a new check for Buffer.alloc
to-buffer 1.1.1 checks for Buffer.from and uses it if it's available. Also I just realized to-buffer is also your project so you knew that already 🙂
I ran the tar-stream tests on my machine, and they passed. After that I used yarn link to pull my modified version of tar-stream into my local copy of Yarn, and found that this fixed the deprecation warnings. So once you merge this PR and release a new version of tar-stream, I'll make a PR to Yarn to bump the tar-stream version there, and that should make the message go away for Yarn users.
mafintosh
commented
5 years ago
I've been seeing warnings for a while when using the Yarn package manager about the
Bufferconstructor API being deprecated in favor ofBuffer.fromandBuffer.alloc.Yarn depends on tar-stream, and two of tar-stream's dependencies use
new Buffer, but happily newer versions of both those dependencies exist that check if the appropriate new API is available and use that instead.Buffer.allocBuffer.fromand uses it if it's available. Also I just realized to-buffer is also your project so you knew that already 🙂I ran the tar-stream tests on my machine, and they passed. After that I used
yarn linkto pull my modified version of tar-stream into my local copy of Yarn, and found that this fixed the deprecation warnings. So once you merge this PR and release a new version of tar-stream, I'll make a PR to Yarn to bump the tar-stream version there, and that should make the message go away for Yarn users.Cheers! -Jake