search

mafintosh / tar-stream

tar-stream is a streaming tar parser and generator.
MIT License
406 stars 92 forks source link

PR for typescript definition? #97

Closed alvis closed 1 year ago

alvis commented 5 years ago

@mafintosh: Do you accept a typescript definition PR for tar-stream? I have one working at https://github.com/alvis/tar-stream/tree/typescript

It would be great if the definition is attached at the source, as any incompatible change can be detected by the test. But I'm aware that some authors prefer not to have the definitions attached at the source. If it's the case, I'd submit it to DefinitelyTyped instead.

mafintosh commented 5 years ago

What do I need to do to help you support this?

alvis commented 5 years ago

@mafintosh nothing. I've got everything working and tested. :)

alvis commented 5 years ago

ping @mafintosh: happy to accept a PR?

mafintosh commented 1 year ago

feel free to pr typings if relevant