search

mafintosh / torrent-stream

The low level streaming torrent engine that peerflix uses
MIT License
1.94k stars 227 forks source link

'npm install' and Visual C++ error #137

Closed watdafox closed 8 years ago

watdafox commented 8 years ago

because of bufferutil and utf-8-validate, I can't build torrent-stream on my machine. It complains about MSB3428 (visual c++) when triggering node-gyp.

Those deps are apparently "optionnal", whatever it means, so idk if it affects the way torrent-stream is supposed to work.

Additonnal info: both deps are used by torrent-discovery\bittorrent-tracker\ws

Ivshti commented 8 years ago

These problems are related to recent changes making torrent-stream and webtorrent using unified dependencies. This is the websocket module of bittorrent-tracker. It should also be used by the peer/swarm module.

ping @feross

feross commented 8 years ago

bittorrent-tracker has depended on the ws module (and thus it's native dependencies) for a long time now, but torrent-stream was using an older version of bittorrent-tracker. The newer version came in when we started depending on torrent-discovery.

When optional dependencies fail to install, everything should work just fine despite npm's ridiculous error spewing. I opened an issue on bittorrent-tracker to look at removing the dependency on ws: https://github.com/feross/bittorrent-tracker/issues/92

feross commented 8 years ago

https://github.com/websockets/ws/issues/577

feross commented 8 years ago

The ws package just removed its native dependencies, so as soon as they publish that to npm this will no longer be an issue!

https://github.com/websockets/ws/commit/49b11093e9a009e5305dcde7003d3a896b2811dc