Implement blocklist using interval-tree, fix #62

mafintosh / torrent-stream

The low level streaming torrent engine that peerflix uses

MIT License

1.94k stars 228 forks source link

Implement blocklist using interval-tree, fix #62 #67

Closed BastienClement closed 10 years ago

BastienClement commented 10 years ago

fix #62

BastienClement commented 10 years ago

This one is ready for merging.

@asapach About the event, I found interesting to be able to distinguish between auto-blocking occurring against a peer and simply a blacklisted peer discovered. I agree however that the use cases for both events is quite limited.

cc #62

asapach commented 10 years ago

Fixed the test after the breaking changes. Peerflix will need to be updated to support the new [start, end] blocklist format.

BastienClement commented 10 years ago

'was about to fix the test. I was so used to my js version of the list that I missed the change from startAddress / endAddress to start / end. Do we keep this change in the API? ( cc @mafintosh )

asapach commented 10 years ago

It's up to @mafintosh :smile:

mafintosh commented 10 years ago

i like smart / end more than the old one :) :+1: from me

mafintosh commented 10 years ago

is this ready for release? if so i'll publish a new version with a minor bump tomorrow

BastienClement commented 10 years ago

It's :+1: for release for me.

asapach commented 10 years ago

There are 32 commits since the previous release :) We definitely need a new one.

mafintosh commented 10 years ago

haha - nice. you guys are way to productive! :)

mafintosh commented 10 years ago

released this and all of the other 32 commits in 0.13.0