search

mafintosh / webrtc-swarm

Create a swarm of p2p connections using webrtc and a signalhub
MIT License
380 stars 60 forks source link

Added close method #14

Closed lukeburns closed 8 years ago

lukeburns commented 8 years ago

Added close method for https://github.com/karissa/hyperdrive-archive-swarm/issues/2

lukeburns commented 8 years ago

Depends on https://github.com/mafintosh/signalhub/pull/22

juliangruber commented 8 years ago

@mafintosh in case you missed this commit ^ @lukeburns idk if you pinged @mafintosh yourself, but since github doesn't notify you about new commits, only new comments, it's generally a good idea to comment as well. if you told him, just ignore this :)

lukeburns commented 8 years ago

Pinged him on IRC!

mafintosh commented 8 years ago

Added final comments. @lukeburns have you tested (somehow) that this is still backwards compatible with we had before? I.e. that this PR can connect with webrtc-swarms running the current master?

mafintosh commented 8 years ago

@juliangruber i've noticed that github just started notifying on new commits!

lukeburns commented 8 years ago

Just tested backwards compatibility by sharing a dat from remote dat.land to a local dat.land running on https://github.com/karissa/hyperdrive-archive-swarm/issues/2 which is running on this.

lukeburns commented 8 years ago

Let me run a couple more tests on compatibility

mafintosh commented 8 years ago

2.6.0