search

mafintosh / webrtc-swarm

Create a swarm of p2p connections using webrtc and a signalhub
MIT License
380 stars 60 forks source link

tests hang and don't complete #19

Closed mreinstein closed 6 years ago

mreinstein commented 7 years ago

repro steps:

git clone https://github.com/mafintosh/webrtc-swarm.git
cd webrtc-swarm
npm i
npm test

console output:

> webrtc-swarm@2.8.0 test /Users/mike/webrtc-swarm
> standard && tape test.js

TAP version 13
# greet and close

the tests don't progress any further and hang here indefinitely.

On a related note, it might make sense to locally run a hub instance rather than relying on https://signalhub.mafintosh.com. It would make the tests more isolated and reduce traffic to your public endpoint as well.

perguth commented 6 years ago

It hangs because the two swarm instances don't have matching "appName" namespaces and thus never see each other (code lines).