search

mafintosh / webrtc-swarm

Create a swarm of p2p connections using webrtc and a signalhub
MIT License
380 stars 60 forks source link

upgrade simple-peer to fix issue with wrtc #9

Closed ghost closed 8 years ago

ghost commented 8 years ago

Before with opts.wrtc:

webrtc-swarm $ node example.js 
/home/substack/projects/webrtc-swarm/node_modules/simple-peer/index.js:419
      self.remoteAddress = remote.ipAddress
                                 ^

TypeError: Cannot read property 'ipAddress' of undefined
    at setActiveCandidates (/home/substack/projects/webrtc-swarm/node_modules/simple-peer/index.js:419:34)
    at /home/substack/projects/webrtc-swarm/node_modules/simple-peer/index.js:439:28
    at Array.forEach (native)
    at /home/substack/projects/webrtc-swarm/node_modules/simple-peer/index.js:434:11
    at /home/substack/projects/webrtc-swarm/node_modules/simple-peer/index.js:397:7
    at /home/substack/projects/node-webrtc/lib/peerconnection.js:311:7

but this was fixed upstream in simple-peer 6.0.1. The simple-peer 5 to 6 jump was related to removing automatic json parsing, which shouldn't affect webrtc-swarm.

mafintosh commented 8 years ago

out in 2.4.0