maforget / CRDataManager

27 stars 2 forks source link

Importing v1 files doesn't parse some character correctly #2

Closed whipflash191 closed 2 years ago

whipflash191 commented 2 years ago

Hi, I'm just getting back into comics and working on updating my install. I tried install your latest version of Data Manager but encounter this error when trying to use it image

maforget commented 2 years ago

Can you post your dataman.dat file?

whipflash191 commented 2 years ago

data manger.zip This should be it, looks like a an compatibility issue with .dat created in an older version of the plugin. I started from scratch with a completely fresh .dat file and it's works perfectly now.

maforget commented 2 years ago

One of the fix for this version is to be able to load v1 dat files like yours. So it should still open it.

The problem comes from using an @ in a rule name. You are using Army @ Love. The @ char is special and used for comments.

So here is the fixed v1 (just renamed Army @ Love to Army at Love in the rule name. And the v2 dat file. data manager v1 Fix + v2.zip

maforget commented 2 years ago

I changed the behavior of the v1 parsing to prevent these kind of problems. https://github.com/maforget/CRDataManagerGUI/commit/915417eef00ba0c8c4cdbc0e13c77b5159b5dca9

You can download the new GUI here (version is r804). https://github.com/maforget/CRDataManager/raw/e6b839eaffa6fca4239815388abb9d40a7b72c9c/crdmgui.exe