search

maforget / ComicRackCE

A Community Edition for the legendary Comic Book Manager ComicRack. ComicRack is back from the dead.
GNU General Public License v2.0
340 stars 34 forks source link

Publisher icons with years no longer work with blank month field #122

Closed devinclancy closed 1 month ago

devinclancy commented 1 month ago

Describe the bug

I added some publisher icons with years specified. They seem to work properly when the full date field is populated. Displayed in UI as (1970/10). When the month is blank, it will use the generic or most recent publisher icon. Displayed as (1970).

Exact Steps to Reproduce

  1. Add file to Publshers.zip.: DC Comics(1970-1971)#DC(1970-1971).png
  2. Open Comicrack CE, select Action Comics.
  3. Scroll to 1970. (Issues 391, 393).
  4. Note differences
  5. Copy same file to old ComicRack.
  6. File displays correctly

Screenshots

ComicRack CE:

comic rack CE publisher logo

Old ComicRack:

comic rack original publisher logo

Version/Commit (check the about page, next to the version, for the string between brackets):

devinclancy commented 1 month ago

[Uploading Publishers.zip…]()

maforget commented 1 month ago

Related to changes done in #111.

maforget commented 1 month ago

Uploading Publishers.zip…

Please reupload it didn't work

devinclancy commented 1 month ago

Publishers.zip

Trying again.

maforget commented 1 month ago

I've also added your DC Comics icons in the last build. b6392f32666f16c53a36f6649c2d6fa0ef25c351