search

maforget / ComicRackCE

A Community Edition for the legendary Comic Book Manager ComicRack. ComicRack is back from the dead.
GNU General Public License v2.0
295 stars 32 forks source link

"Show in List" Redirects Incorrectly #43

Closed carfa34 closed 7 months ago

carfa34 commented 7 months ago

Describe the bug When using "Show in List" on any comic file, it redirects to whatever the last "List" option is regardless of what is chosen.

Exact Steps to Reproduce Steps to reproduce the behavior:

  1. Right click any comic file.
  2. Click on 'Show in List'
  3. Click any List option.
  4. Be redirected to whatever last List option is.

Screenshots Attached short video clip. Can provide more if needed.

Version/Commit (check the about page, next to the version, for the string between brackets):

Additional context Not a big issue, just an inconvenience. The bug is there on current latest build "44d1d2" and whatever was the most recent one. Can't remember if it was there on earlier builds.

https://github.com/maforget/ComicRackCE/assets/151964748/884bd53f-98dd-43bd-8f4b-0ab7b7317e98

maforget commented 7 months ago

Ok that was weird, never touched that part. It was because of the decompilation the variable was declared before the loop instead of inside. It's been a while since I decompiled this, newer program show it properly.