maforget / ComicRackCE

A Community Edition for the legendary Comic Book Manager ComicRack. ComicRack is back from the dead.
GNU General Public License v2.0
213 stars 20 forks source link

Disabled the Dialog for saving changes to Non-DB files if AutoUpdateComicFiles is active #48

Closed flaser closed 4 months ago

flaser commented 4 months ago

Disabled the Dialog for saving changes to Non-DB files if AutoUpdateComicFiles is active.

This should fix issue: https://github.com/maforget/ComicRackCE/issues/45

maforget commented 4 months ago

I can't merge this, as discussed, check the source of the problem. AKA: why is the book dirty when you claim it's not.

If I merge this then all those that have books pending to be automatically updated and haven't will lose changes. So either you are right and there is a bug in the reporting of books to be updated when they have already or you are wrong and everyone looses data.

Also keep in mind that if a malformed file if found the info is null, so any changes are a change. Needs to see if Shadow (Proposed Value) changes are considered as making the book Dirty.