mafpovbul / pe

0 stars 0 forks source link

Corrupted Save File for customer #10

Open mafpovbul opened 2 years ago

mafpovbul commented 2 years ago

Does not check for data validity from customer saved file.

image.png image.png

nus-pe-bot commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unhandled exception thrown when user change the data file manually

Screen Shot 2022-04-16 at 5.09.49 PM.png

Screen Shot 2022-04-16 at 5.10.23 PM.png The app simply cannot restart and DOS.


[original: nus-cs2113-AY2122S2/pe-interim#1317] [original labels: type.FunctionalityBug severity.High]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

It doesn't make reasonable sense for anyone to tamper with the data directly from a file, furthermore, the whole purpose of this CLI is to enable users to delete/add what they deem through the CLI. If they can tamper the database, then it really just defeats the whole purpose of the CLI. Throughout this project, it is assumed that the user cannot tamper with the database. In a real work environment, databases are encrypted and you would need certain password etcs to actually edit manually from the database, so this is just unrealistic.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.High] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]