search

mag1024 / bosch-alarm-homeassistant

Integration for Bosch Alarm panels that use the mode2 protocol: Solution, B/G series, AMAX
26 stars 4 forks source link

Submit to HACS #8

Closed mag1024 closed 2 months ago

mag1024 commented 1 year ago

Until this is upstreamed to HA, it would make the installation smoother if the integration was listed in the HACS repository tracker

sanjay900 commented 1 year ago

Yeah this is a good idea, i have already seen people get confused by it not being in the HACS repository. What are we waiting on before we look at upstreaming it to HA?

mag1024 commented 1 year ago

Somehow I don't think that upstreaming will be a particularly quick process, so if it's easy enough, I think we should do it.

sanjay900 commented 1 year ago

For HACS, we need to wait for the icons to be merged, but you will need to set some topics on the repo @mag1024 Ive set the rest of the required stuff up for HACS, including the CI pipelines for validating everything. Do we want to set up a proper info.md file or just leave it as the readme?

mag1024 commented 1 year ago

Thanks! Added some random tags -- lemmy know if there are any other relevant ones you can think of. I can't think of anything we'd put in info.md that wouldn't duplicate what we have in the readme, so unless it's required, I don't see much point. Should we start tagging releases for the integration s.t. HACS can reference them?

sanjay900 commented 1 year ago

We can set up some proper release pipelines, we need to do proper GitHub releases if we want to go that route, not just tags.

sanjay900 commented 1 year ago

The funny thing is that it sounds like its a very slow process to get things in HACS, so once we get some tests done its probably worth opening the merge requests to just get it upstreamed into home assistant proper. Have you got much experience with python tests?

sanjay900 commented 1 year ago

Now that the icons are in, the prerequisite checks are passing. iirc while we probably should use releases and version numbers it's not actually a requirement for HACS

sanjay900 commented 11 months ago

@mag1024 would you prefer to raise the issue in HACS, or should I? Might as well get that process underway.

We will need to sort the tests before upstreaming to home assistant proper, but i think we also should solve https://github.com/mag1024/bosch-alarm-homeassistant/issues/24 before that as well.

mag1024 commented 11 months ago

Started a HACS PR here: https://github.com/hacs/default/pull/2214