Use `catkin_install_python` to install legacy relay. #noetic

magazino / move_base_flex

Move Base Flex: a backwards-compatible replacement for move_base

https://uos.github.io/mbf_docs/

BSD 3-Clause "New" or "Revised" License

429 stars 154 forks source link

Use `catkin_install_python` to install legacy relay. #noetic #219

Closed FabianSchurig closed 4 years ago

FabianSchurig commented 4 years ago

According to Changing_shebangs we need to install python scripts with catkin_install_python() to let catkin decide whether to run it with Python 2 or 3. This makes it runnable on future distributions, e.g. Ubuntu 20.04 focal and ROS noetic, as well as on older ones like 18.04 bionic and melodic.

corot commented 4 years ago

Thanks @Bitfroest !

simonbogh commented 3 years ago

Has this been released because I am still getting the error from binary install on Noetic?

rokusottervanger commented 3 years ago

Has this been released because I am still getting the error from binary install on Noetic?

I don't think so. I also got the error, so I compiled from source.

spuetz commented 3 years ago

For noetic there will be a release which breaks the current API, see https://github.com/magazino/move_base_flex/issues/216 We are working on it.

spuetz commented 3 years ago

Nevertheless, I can release the current melodic and kinetic version for noetic. But noetic is developed in the noetic-devel branch.