magazino / move_base_flex

Move Base Flex: a backwards-compatible replacement for move_base
https://uos.github.io/mbf_docs/
BSD 3-Clause "New" or "Revised" License
424 stars 154 forks source link

enable max retries logic for controller execution test #264

Closed juliangaal closed 3 years ago

juliangaal commented 3 years ago

Keep in mind that the #261 PR will provide some testing the affected class (but I would need to adjust the tests to the changed behavior). source

Attemps to fix the controller execution test broken since #263

Steps taken to pass this condition:

else
{
  setState(NO_LOCAL_CMD); // useful for server feedback
  // we keep on moving if we have retries left or if the user has granted us some patience.
  moving_ = max_retries_ || !patience_.isZero();
}
if (max_retries_ > 0 && ++retries > max_retries_)
{
  setState(MAX_RETRIES);
  moving_ = false;
}

Cheers

dorezyuk commented 3 years ago

@juliangaal cool thanks for the fix