search

magazino / move_base_flex

Move Base Flex: a backwards-compatible replacement for move_base
https://uos.github.io/mbf_docs/
BSD 3-Clause "New" or "Revised" License
424 stars 154 forks source link

Implement getRobotVelocity on RobotInformation and use on executions instead of tf #293

Closed corot closed 2 years ago

corot commented 2 years ago

How can I run locally run-style-check-diff.sh so I format only the modified lines?

Our system is a bit cumbersome... as I need to format just the modified lines :thinking: So I'll let the previous format

corot commented 2 years ago

About the formatting.... are u ok with an extra commit formatting to clang the modified code? some files have wrong indentation, so changes will look bigger than what they really are

Maybe I can do after having the approvals

corot commented 2 years ago

Ok, I coopted odom helper. Ready for a final review, @dorezyuk, @spuetz

And let me know what I do with the formatting; I have the commit waiting for after your reviews

spuetz commented 2 years ago

Yea please change the formatting back. Formatting all the other files should be in a separate PR. I hope this is not too much work. Cheers - Seb

corot commented 2 years ago

Yea please change the formatting back. Formatting all the other files should be in a separate PR. I hope this is not too much work. Cheers - Seb

No, no,,, I didn't format anything on the PR. I was just explaining why the check fails and offering to address that