Open Jmeyer1292 opened 2 years ago
Thanks for the thorough analysis. I agree, at first glance, looks like a continue;
is missing.
I'll try myself and see if there's any good reason for not having it (we wrote that logic long time ago, and I don't remember the rationale)
Greetings. MoveBaseFlex is an excellent piece of software. Thank you for the hard work in creating and maintaining it.
I wanted to report an issue: In brief the
safetyChecks
are not working as expected.Blue is a velocity command (
Figure 1
linear/x
). Red is measured robot twist (linear/x
).A very quick glance through the source code shows this section of code as the point where our checks are applied.
It appears that the safety check fails (as expected), a zero velocity is published, and the thread sleeps. It then proceeds to go and run the controller and issue a command anyway. I suggest the inclusion of a
continue
in the loop where the safety checks fail.I'm happy to make this edit, but I acknowledge that this may have been done on purpose. I can certainly see the value in still running controllers at regular intervals and just letting them know that things are kinda broken.
Again thank you for being open source maintainers.