magazino / move_base_flex

Move Base Flex: a backwards-compatible replacement for move_base
https://uos.github.io/mbf_docs/
BSD 3-Clause "New" or "Revised" License
434 stars 154 forks source link

Hiding Errors on Initialization #331

Open AlexanderDavid opened 10 months ago

AlexanderDavid commented 10 months ago

https://github.com/magazino/move_base_flex/blob/c02460e9bc1dbfb2e82348b308cc3fa1e3d12cda/mbf_abstract_nav/include/mbf_abstract_nav/impl/abstract_plugin_manager.tcc#L106

This try catch block will catch any XMLRPC value errors and incorrectly attribute them to the controller parameter structure. It would probably be better to just say there was an XMLRPC error when loading the plugin and let the user figure out the issue.